search

PecanProject / BETYdb-YABA

Yet Another BETYdb API (for metadata upload)
BSD 3-Clause "New" or "Revised" License
5 stars 18 forks source link

Added DUMPURL for fixing "Not able to find a sync_url in database - ERROR: 255 " #85

Closed cryolune closed 3 years ago

cryolune commented 3 years ago

issue #84

dlebauer commented 3 years ago

Awesome, thanks for submitting this PR!

Looks good, just need to check why the test and linter checks are failing (do you know @im-prakher ?)

im-prakher commented 3 years ago

@theakhiljha Implement this locally then make a commit, $git checkout -b temp $ git checkout master $ git merge temp $ git branch -d temp This should work for linter test

codecov-io commented 3 years ago

Codecov Report

Merging #85 (f023da5) into master (16da1c2) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #85   +/-   ##
======================================
  Coverage    6.53%   6.53%           
======================================
  Files          20      20           
  Lines         597     597           
  Branches       68      68           
======================================
  Hits           39      39           
  Misses        506     506           
  Partials       52      52

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16da1c2...f023da5. Read the comment docs.

cryolune commented 3 years ago

@im-prakher I tried to implement this locally and followed the commands you gave to fix the linter test issue but it didn't work.