search

Pectojin / duplicati-client

A command line client for controlling the Duplicati Server
GNU Lesser General Public License v2.1
75 stars 20 forks source link

Fix auth #9

Closed mjmayer closed 6 years ago

mjmayer commented 6 years ago

This addresses #7 . I believe the issue was authorization was defined as '' in config.yml. Then it was setting the basic auth header and trying to pass that along to the duplicati webserver. https://github.com/Pectojin/duplicati_client/blob/697b7f3b5675a0ae27d83ab8465d1c4ac5f42900/common.py#L120-L122 There was also an issue that when using basic auth the script would exit even though basic pass, password, and basic username were all defined.

I also added some unit tests.

I've tested the login process against basic auth and duplicati integrated auth.

Pectojin commented 6 years ago

This looks very nice! I've confirmed on my end it also fixes the issue on my Alpine image.

The tests are a welcome change, too. I must admit that had not made it very high on my priority list.

Thanks a lot @mjmayer