search

PeerHerholz / BIDSonym

a BIDS app for pseudo-anonymization of neuroimaging data
https://peerherholz.github.io/BIDSonym/
BSD 3-Clause "New" or "Revised" License
51 stars 12 forks source link

at least warn whenever incorrect/missing participant id is specified #26

Closed yarikoptic closed 4 years ago

yarikoptic commented 4 years ago

I have misread --help and specified sub id with sub- prefix.

smaug:~/proj/nuisance/data/dbic-deid$ envs/bidsonym_latest.sif sourcedata participant --participant_label=sub-sid000003 --deid pydeface
Making sure the input data is BIDS compliant (warnings can be ignored in most cases).
This dataset appears to be BIDS compatible.

        Summary:                   Available Tasks:        Available Modalities: 
        1115 Files, 11.56MB                                T1w                   
        206 - Subjects                                                           
        370 - Sessions                                                           

    If you have any questions, please post on https://neurostars.org/tags/bids.

smaug:~/proj/nuisance/data/dbic-deid$ echo $?
0

as you can see -- nothing really happened and even no non-0 exit code

PeerHerholz commented 4 years ago

Should be addressed via this commit. If the specified participant label is not in the list of included participants, the process stops and provides the label of the missing participant.

yarikoptic commented 4 years ago

invaluable advice from yours truly: use Closes #XXX (not addresses) statement in your commit or PR messages etc to avoid the need for the manual closing of issues etc. See e.g. historical note from 2013: https://github.blog/2013-01-22-closing-issues-via-commit-messages/ ;-)