PeggyJV / sommelier-strangelove

https://sommelier.strangelove.ventures/
5 stars 4 forks source link

Sell modal next iteration #756

Open henrio123 opened 1 year ago

henrio123 commented 1 year ago

Update "Buy" model with the next design and parameters:

*ETH-BTC Trend and ETH-BTC Momentum already have this upgrade and can reuse these developments for other Strategies

With strategy token - Image

With out strategy token (only Aave strategy)- Image

Figma: https://www.figma.com/file/7IAQbLyzapnrow9sIcO77P/App?node-id=2237%3A112286&t=jJzktGPY9zxaL0U3-0

henrio123 commented 1 year ago

@codingki I tested but found few things -

  1. For all "Automated Portfolio Management" strategies, "Asset" and "Estimated USD" doesn't load -

Image

  1. For Aave strategy I think modal is not updated -

Image

codingki commented 1 year ago
  1. It's because you encounter a 429 error (too many request) from coin gecko. We haven't put an error state there. I'll create an error state there.
  2. Aave doesn't have asset distribution
henrio123 commented 1 year ago

@codingki we can move it to production and lets do Aave separately if this is not done yet

codingki commented 1 year ago

error state added, merged to prod. Yes we can do Aave separately