search

PelicanPlatform / pelicanfs

An fsspec implementation that uses the pelican client
https://pelicanplatform.org/
Apache License 2.0
1 stars 4 forks source link

Fixed an issue where the mapper already has https:// address assigned… #42

Closed turetske closed 6 months ago

turetske commented 6 months ago

… during creation but the url parsing was failing to catch it

Added a test of the get_mapper to the code

turetske commented 6 months ago

This is meant to be a temporary fix. There is an issue which discusses a more long term solution: https://github.com/PelicanPlatform/pelicanfs/issues/43

turetske commented 6 months ago

LGTM. Thank you for dropping in a unit test (and a comment) so it's obvious to future readers why the non-pelican:// check exists.

Note this won't work with http:// URLs (which can still exist for some caches, no?).

Good point, I'll add that as a check as well.