search

PennLINC / qsiprep

Preprocessing of diffusion MRI
http://qsiprep.readthedocs.io
BSD 3-Clause "New" or "Revised" License
141 stars 58 forks source link

[FIX] Include linear interpolation (#829) #839

Closed araikes closed 2 weeks ago

araikes commented 4 weeks ago

Add "Linear" into _ChooseInterpolatorOutputSpec

Changes proposed in this pull request

Fixes the missing "Linear" interpolator option. Current behavior is to use linear interpolation when upsampling but the output spec lacks "Linear" as a possible value. Retains BSpline as an option as this may be used in the future and having it as an output spec option doesn't impact anything.

Fixes #829.

Documentation that should be reviewed

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.13%. Comparing base (551bacd) to head (fa463b6). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #839 +/- ## ======================================= Coverage 28.13% 28.13% ======================================= Files 69 69 Lines 10080 10080 Branches 1106 1106 ======================================= Hits 2836 2836 Misses 7146 7146 Partials 98 98 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 2 weeks ago

It looks like @mattcieslak added that interpolator in #832, so I'm going to close this.