PennyLaneAI / catalyst

A JIT compiler for hybrid quantum programs in PennyLane
https://docs.pennylane.ai/projects/catalyst
Apache License 2.0
142 stars 36 forks source link

[build system] Ship with catalyst lock for the python interpreter #1257

Closed erick-xanadu closed 3 weeks ago

erick-xanadu commented 4 weeks ago

Context: The library libcatalyst_python_interpreter.py's only purpose is to have a mutex for threads to share the python interpreter. This library is not explicitly shipped by Catalyst but it is implicitly included in Catalyst by auditwheel repair and delocate wheel in Linux and macOS respectively.

Description of the Change: This change fixes the rpath and includes the library explicitly to avoid relying on these processes.

Benefits: The build script is more explicit.

Note that this does not yet fixes the makefile to have something like make wheel && python -m pip install dist/PennyLane_Catalyst-0.10.0.dev0-cp311-cp311-linux_x86_64.whl

[sc-77254]

github-actions[bot] commented 4 weeks ago

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md on your branch with:

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.95%. Comparing base (b62d763) to head (e541f63). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1257 +/- ## ======================================= Coverage 97.95% 97.95% ======================================= Files 77 77 Lines 11319 11319 Branches 981 981 ======================================= Hits 11088 11088 Misses 181 181 Partials 50 50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

erick-xanadu commented 3 weeks ago

We may close this one in favour of #624 .

erick-xanadu commented 3 weeks ago

Closed in favour of #624