PennyLaneAI / catalyst

A JIT compiler for hybrid quantum programs in PennyLane
https://docs.pennylane.ai/projects/catalyst
Apache License 2.0
142 stars 36 forks source link

Fix failing string `repr` tests #1263

Closed joeycarter closed 4 weeks ago

joeycarter commented 4 weeks ago

Context: Core PennyLane changed the string representation for some operators: https://github.com/PennyLaneAI/pennylane/pull/6493. For example "Adjoint(S(wires=[0]) + T(wires=[0]))" -> "Adjoint(S(0) + T(0))". Catalyst contains a few tests that check these string representations, so these tests need to be updated.

Description of the Change: Update string representations for all failing tests.

github-actions[bot] commented 4 weeks ago

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md on your branch with:

joeycarter commented 4 weeks ago

Thanks you so much @joeycarter, sorry for the trouble

No worries!

mudit2812 commented 4 weeks ago

Once https://github.com/PennyLaneAI/pennylane/pull/6499 is merged into PL, you should be able to update .dep-versions with the merge commit SHA, which should fix the failures.

joeycarter commented 4 weeks ago

Once PennyLaneAI/pennylane#6499 is merged into PL, you should be able to update .dep-versions with the merge commit SHA, which should fix the failures.

For the Catalyst RC branch, we install PL directly from the v0.39.0-rc0 branch on GitHub, so hopefully once that PR is merged we can rerun the RC/RC/RC and it will work without having to change .dep-versions.

If the RC/RC/RC build passes after merging in the revert commit, the we can close this PR without merging.

joeycarter commented 4 weeks ago

The CPL rc/rc/rc build is now passing after reverting the PR in PennyLane that changed the string representation, so this PR is no longer needed. Closing.