Apply clang-tidy to runtime capi directory

PennyLaneAI / catalyst

A JIT compiler for hybrid quantum programs in PennyLane

https://docs.pennylane.ai/projects/catalyst

Apache License 2.0

142 stars 36 forks source link

Apply clang-tidy to runtime capi directory #1273

Closed paul0403 closed 3 weeks ago

paul0403 commented 3 weeks ago

Context: We keep applying clang-tidy suggestions to the files in runtime.

Description of the Change: Apply clang-tidy to runtime capi directory.

Benefits: Better following of clang rules; unblocks the moving of lightning files from catalyst repo to lightning repo.

Related GitHub Issues: closes #1271 [sc-77391]

github-actions[bot] commented 3 weeks ago

Hello. You may have forgotten to update the changelog! Please edit doc/releases/changelog-dev.md on your branch with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

paul0403 commented 3 weeks ago

Discussed offline, we will skip smart pointers here to quickly unblock lightning downstreaming, and do smart pointers in a separate PR #1284

paul0403 commented 3 weeks ago

@rauletorresc I think https://github.com/PennyLaneAI/catalyst/pull/1273/commits/95facd7f86e430aec520bf1a8c6d515b7828e01c is good to go. Can you run tidy in your Lightning PR to make sure?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.95%. Comparing base (183a43c) to head (5434c0e). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1273 +/- ## ========================================== - Coverage 97.95% 97.95% -0.01% ========================================== Files 77 77 Lines 11319 11318 -1 Branches 981 981 ========================================== - Hits 11088 11087 -1 Misses 181 181 Partials 50 50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.