Open JerryChen97 opened 1 week ago
The three fails up to now are all expected; will fix when the blockers were removed and this branch got updated
@lillian542 I just rebased to the measure
branch. There might be still some confusing out-of-scope changes somehwere e.g. a little fix regarding init_state over the other PR; but this PR's primary purpose is to introduce the added file simulate.py
as well as its test suite
Attention: Patch coverage is 95.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 99.64%. Comparing base (
ff09567
) to head (c266b34
). Report is 5 commits behind head on add-qubit_mixed/measure.
Files with missing lines | Patch % | Lines |
---|---|---|
pennylane/devices/default_mixed.py | 66.66% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before submitting
Please complete the following checklist when submitting a PR:
[ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the test directory!
[ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running
make docs
.[ ] Ensure that the test suite passes, by running
make test
.[ ] Add a new entry to the
doc/releases/changelog-dev.md
file, summarizing the change, and including a link back to the PR.[ ] The PennyLane source code conforms to PEP8 standards. We check all of our code against Pylint. To lint modified files, simply
pip install pylint
, and then runpylint pennylane/path/to/file.py
.When all the above are checked, delete everything above the dashed line and fill in the pull request template.
Context: The implementation of method
simulate
is the most important one under the architecture of new API standard. The point ofsimulate
, is basically abstract both the analytic version (controlled byshots=None
, or infinite shots in a fancier way) and the MC version (finite shots). Meanwhile, the functionality of such method should not truly depend on our details of qml implementationi; they better only rely on either the fundamental computation libs, e.g. math lib and qnp, or the most essential infras, e.g. Tape/Scripts and Operations.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: [sc-73320]