search

PennyWieser / Thermobar

Python thermobarometry tool
41 stars 10 forks source link

calculate_fspar_liq_temp_hygr_matching() Kd Test Issue #30

Closed bwplatt closed 1 year ago

bwplatt commented 1 year ago

I encountered an issue with the An-Ab Eq test filter in the calculate_fspar_liq_temp_hygr_matching() function. The Pass An-Ab Eq Test Put2008 field indicates that the feldspar analyses passed the low temperature EQ test (all calculated temperatures were below 1300 K), however all of the values in the Obs_Kd_Ab_An field were between 0.17 and 0.29. These values would pass the high temperature test from Putirka (2008; 0.17-0.39) but would fail the low temperature test (0.05 - 0.15). Based on this, I suspect that there is an error in how the Kd test for this function is handled.

PennyWieser commented 1 year ago

Thanks for this Bryant! Can you email me your Jupyter notebook and some example data causing this so I can look into it in more detail?

PennyWieser commented 1 year ago

Fixed this now. There was a typo so it read yes instead of No. Thanks for spotting! If you upgade to v1.0.11 (give it maybe 10 mins) this will work as expected now.