search

PennyWieser / Thermobar

Python thermobarometry tool
41 stars 10 forks source link

Fix Mistake in convert_fO2_to_fe_partition #52

Open fboschetty opened 2 weeks ago

fboschetty commented 2 weeks ago

Fixed reference to 'logfo2_offset', which should read 'fo2_offset' around line 4172. Updated formatting to improve readability

PennyWieser commented 1 week ago

Hi Felix, I independently was working on a bug fix for this. I cant follow exactly what you changed as a lot of the changes are just entering of new lines which is making it super hard to follow. I'm hoping my fix is the same as your fix? But let me know if not. I also added some more buffers.

fboschetty commented 4 days ago

Hi Penny,

The issue was on line 4172. The code references 'logfo2_offset' which doesn't exist. It should be 'fo2_offset' instead. Doesn't look like that's changed as of today.

Felix