search

PerCollECT / Source-Files

Source files for PerCollECT visualization. This is included in the PerCollECT repos as a submodule.
MIT License
2 stars 2 forks source link

36 clicking on search result does not open the node #38

Closed ehab74 closed 10 months ago

ehab74 commented 11 months ago

It should be working.

About the animation of the node if it wasn't already displayed, do you feel it is not important or doesn't add much?

ChristophPopp commented 10 months ago

About the animation of the node if it wasn't already displayed, do you feel it is not important or doesn't add much?

I think the animation is still good in this case, since the user can see that the part of the tree changes that was visible before. However, it would be useful to also change the viewbox (smoothly) such that the searched and highlighted node is visible in the viewbox.

ehab74 commented 10 months ago

Okay i made the viewbox to move to the node found by the search.

One last thing, if the node found by the search bar is already displayed, do you want the viewbox to move to it or it is not important?

ChristophPopp commented 10 months ago

Okay i made the viewbox to move to the node found by the search.

One last thing, if the node found by the search bar is already displayed, do you want the viewbox to move to it or it is not important?

Nice! If the node found in the search bar is already expanded but not within the viewbox, the viewbox should also move such that the node is visible in the viewbox for the user.

ehab74 commented 10 months ago

Nice! If the node found in the search bar is already expanded but not within the viewbox, the viewbox should also move such that the node is visible in the viewbox for the user.

Okay i will add it.

ehab74 commented 10 months ago

It should be working now.