search

Pergor / ADV_Medical

ADV- ACE Medical mods
16 stars 17 forks source link

RPT spam #20

Open Tommo-S opened 5 years ago

Tommo-S commented 5 years ago

Hi Belbo,

I noticed a minor error in fn_actionCheckPulseLocal.sqf that leads to RPT spam whenever you check someone's pulse. It will spam string %1 checked Heart Rate: %2 not found to the RPT 30 or so times over 5 seconds.

I'm not great at github so please forgive me.

https://github.com/Pergor/ADV_Medical/blob/47d1c83ead8cdda0732e6488b55c8fdb424ab504/adv_aceCPR/functions/fn_actionCheckPulseLocal.sqf#L67 https://github.com/Pergor/ADV_Medical/blob/47d1c83ead8cdda0732e6488b55c8fdb424ab504/adv_aceCPR/functions/fn_actionCheckPulseLocal.sqf#L68

The word localize isn't required in lines 67 or 68, the ACE function handles localization, you just tell the ACE function which string to use.

[_unit,"activity", "STR_ACE_Medical_Check_Pulse_Log",[[_caller] call ace_common_fnc_getName,_logOutPut]] call ace_medical_fnc_addToLog; [_unit,"quick_view", "STR_ACE_Medical_Check_Pulse_Log",[[_caller] call ace_common_fnc_getName,_logOutPut]] call ace_medical_fnc_addToLog;

Pergor commented 5 years ago

You might be right there, the original function just takes LSTRING(Check_Pulse_Log). I'll implement a fix.

Pergor commented 5 years ago

Should be fixed with https://github.com/Pergor/ADV_Medical/commit/578c8655029fc64dd459f4ced76f518475509310

Please report back in, if the issue persists.