PeriodPals / periodpals

3 stars 1 forks source link

Feat/profile/fit screens to figma #165

Closed francelu closed 3 weeks ago

francelu commented 3 weeks ago

Make Profile Screens Fit Our Design Flow Idea

Description

This PR introduces significant updates to ensure the components of the profile-related screens adhere to our design flow idea, closely aligning with Figma specifications (subject to updates for M2). It closes issue #158, subtask from #82.

Changes

Test Class Updates

Removed all references to the email field in CreateProfileTest and EditProfileTest classes.
- Deleted test cases: createInvalidProfileNoEmail and editInvalidProfileNoEmail.

UI Component Adjustments

Modified ProfileSection in ProfileComponents.kt to fill the width and align text to the start.
Updated CreateProfileScreen to remove the email field and adjust other layout elements.

Resource Constants

Removed constants related to the email field in C.kt.
Updated other constants to reflect the revised UI structure.

Profile Screen Tests

Added new assertions for UI elements in ProfileScreenTest, covering the contribution field and reviews section.

Files

Added

N/A

Modified

CreateProfileScreen.kt
ProfileComponents.kt
EditProfileScreen.kt
CreateProfileTest.kt
ProfileScreenTest.kt
EditProfileTest.kt
C.kt

Removed

Email-related constants and test cases

Dependencies Added

N/A

Testing

Updated tests to reflect changes in profile screen layouts.
Verified the removal of email-related tests does not impact overall test coverage.

Screenshots

Screen	Before	After
CreateProfileScreen
ProfileScreen
EditProfileScreen

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud