PeriodPals / periodpals

3 stars 1 forks source link

Fix/style/layout responsivness/profile screen #174

Closed francelu closed 2 weeks ago

francelu commented 2 weeks ago

Responsive layout for ProfileScreen

Description

This PR introduces a responsive layout (padding, design and typographies) for the ProfileScreen. It closes issue #172, subtask from #82.

Changes

Files

Added

None.

Modified

Removed

None.

Dependencies Added

None.

Testing

Screenshots

Screen Before After
Compact S image image
Compact M image image
Compact L image image
Medium (horizontal) image image
Medium image image
Extended image image
francelu commented 2 weeks ago

Suggestions

* No further changes are necessary to the documentation as the wiki covers the details well. However, it could be helpful to add inline comments explaining any non-obvious layout decisions, especially if any specific assumptions are made.

@taghizadlaura
What do you mean by non-obvious layout decisions ? Could you point out in the code please ?

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

taghizadlaura commented 2 weeks ago

@francelu Sorry, I thought I had removed this part in my review and replaced it when I saw you created a wiki. However, it seems I only added the wiki comment instead of replacing the entire sentence—it's a typo. My apologies