RFC/Classes: Some (hopefully uncontroversial) suggestions

Perl-Apollo / Corinna

Corinna - Bring Modern OO to the Core of Perl

Artistic License 2.0

156 stars 19 forks source link

RFC/Classes: Some (hopefully uncontroversial) suggestions #46

Closed HaraldJoerg closed 2 years ago

HaraldJoerg commented 2 years ago

The "Lost in Space" character goes by Dr. Zachary Smith
The example code to require a mimimum version for a base class contained a version specification for the actual class, I added the version specification for the parent class.
The class in the "Roles" example should be a copy of the "Customer" class and not of the base class "Person"
If you overload with a method, its signature must match the overloading spec and have two parameters, not zero

HaraldJoerg commented 2 years ago

Ooops... GitHub magic surprised me. My brute-force approach to include your recent commit closed the PR. I can't reopen because GitHub claims I have new commits in my fork (that's your recent update) so I'll prepare a fresh one.