search

PermanentOrg / infrastructure

The infrastructure management for Permanent.org
GNU Affero General Public License v3.0
5 stars 4 forks source link

Update node to version 14.18.3 on backend instance #121

Closed liam-lloyd closed 1 year ago

liam-lloyd commented 1 year ago

Recent security-related updates to notification-service have caused notification-service to have dependencies that won't run on node 12, but require at least node 14. Conveniently, we've been testing our node projects against node 14 (in addition to 12) for some time, so it should be safe to upgrade.

cecilia-donnelly commented 1 year ago

It might be best to go to 14, close https://github.com/PermanentOrg/upload-service/pull/54, but update the tests on upload-service and notification-service to start testing against 16 (and 18?) as well in preparation for the next bump up.

liam-lloyd commented 1 year ago

It might be best to go to 14, close PermanentOrg/upload-service#54, but update the tests on upload-service and notification-service to start testing against 16 (and 18?) as well in preparation for the next bump up.

This seems like the right path to me. Going to 16 would solve notification-service's problems but given that we haven't been testing against 16 it seems safer to start with 14