Closed tolgaOzen closed 1 month ago
[!CAUTION]
Review failed
The pull request is closed.
The pull request introduces extensive updates to the API documentation and underlying functionality of the Permify API. Key changes include the addition of new parameters and endpoints, modifications to existing endpoints, updates to response schemas, and enhancements to validation logic. Additionally, several structural changes were made to the LookupEngine
, SubjectFilter
, and DataReader
components, improving their operational clarity and efficiency. The overall modifications aim to enhance the API's capabilities for managing permissions and data.
Files | Change Summary |
---|---|
docs/api-reference/apidocs.swagger.json, docs/api-reference/openapiv2/apidocs.swagger.json | - Added arguments field in LookupSubjectBody .- Introduced new endpoints: /v1/tenants/{tenant_id}/permissions/lookup-entity-stream , /v1/tenants/{tenant_id}/permissions/lookup-subject , /v1/tenants/{tenant_id}/permissions/subject-permission .- Updated response schemas and security definitions. |
internal/engines/lookup.go, internal/engines/massSubjectFilter.go, internal/engines/subjectFilter.go, internal/engines/utils.go | - Updated LookupSubject to use IdResponse structure.- Removed MassSubjectFilter .- Renamed SchemaBasedSubjectFilter to SubjectFilter and updated related methods.- Introduced new helper functions for ID management. |
internal/storage/decorators/circuitBreaker/dataReader.go, internal/storage/decorators/singleflight/dataReader.go, internal/storage/memory/dataReader.go, internal/storage/postgres/dataReader.go, internal/storage/storage.go | - Updated QueryUniqueSubjectReferences method to include excluded []string parameter for filtering.- Maintained overall structure of DataReader . |
pkg/pb/base/v1/service.pb.validate.go, proto/base/v1/service.proto | - Enhanced validation for PermissionLookupSubjectRequest with new arguments field.- Updated field numbers for page_size and continuous_token due to the addition of arguments . |
apidocs.swagger.json
, which includes modifications to the page_size
parameter and other formatting corrections. This is related to the main PR as both involve updates to the API documentation, specifically in the same apidocs.swagger.json
files.🐰 In the meadow where changes bloom,
New endpoints sprout, dispelling gloom.
Arguments added, clarity shines,
With filters and schemas, all aligns.
Permissions dance in a structured way,
Hooray for the updates, hip-hip-hooray! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Refactor