PersonTheCat / OreStoneVariants

A powerful utility for generating new blocks when given a foreground and background.
GNU General Public License v3.0
7 stars 8 forks source link

Null Pointer generating sprites #22

Closed pupnewfster closed 6 years ago

pupnewfster commented 6 years ago

https://paste.dimdev.org/voxuhorici.mccrash

version: 2.20

Now instead of just crashing on dense #17 I seem to just crash in general when it is trying to load because the buffered image being passed to getColorsFromImage is null.

PersonTheCat commented 6 years ago

Damn it. I'll look through the mod list and see if there are any there I haven't tested that maybe I forgot something for and then try to fix it when I get home in a few hours.

PersonTheCat commented 6 years ago

Okay. While I will admit to not having tested literally every mod I support, here's what I have tried:

I have tested both running the game through Eclipse (1.12.1 - Forge v...2478) and using the Minecraft Launcher (1.12.2 - Forge v...2705), although I have not consistently tested every single one of these mods in both versions.

I also regularly include these entries in my variant adder

            minecraft, netherrack
            coal_ore, log:2
            minecraft, stained_hardened_clay:*

As well as several modified ores in ore_stone_variants_mods and a few totally new ores, one of which is inside of a normal folder instead of a zip file.

Between each attempt at launching the game, I've deleted resources.zip. Yet not once today have I run into this same problem you described. Since version 2.20 was released. There have been a few more changes to the texture stitching process as I try to create more and more unified methods for handling things. A slightly out of date version is here on GitHub, but the most current version actually moves even more functionalities into OreProperties, which now directly store their textures as well (though I may create a TextureProperties object inside of OreProperties to handle this in the future). I say all of this because it's possible that one of these changes has yet again allowed me to escape this issue before ever seeing it.

If you like, it would help me a lot if you could try this new version below. It may work, but if it doesn't, it will also display a million print lines that will tell me specifically which texture isn't working, which piece of information is missing (hopefully), and (if it's a dynamic block) whether the block itself didn't super the correct information into BlockOresBase. Just let me know. Thanks!

ore_stone_variants-2.20.1.zip

Edit: Also, some of the new changes to the config file class crashed my game just one time the first time I ran the game normally. Nothing was changed or broken in the config file and the problem subsequently went away. Not sure what happened or if that's still an issue.

pupnewfster commented 6 years ago

I did not crash at all with the 2.20.1 version you attached, however the file size went from ~85KB to 48 KB so that is always nice given it seems all ores still have their proper textures.

PersonTheCat commented 6 years ago

Huh. I wonder why. There have been a few times where the file paths have changed slightly, but I've always ignored it because the only thing that matters for resource packs is that the actual filenames be the same, I believe. Anyway, thanks for confirming that!