PeteGoo / tcSlackBuildNotifier

Posts build notifications to Slack
MIT License
311 stars 79 forks source link

Question: Bad Link on Running - Not a bug, maybe a configuration setting? #151

Open edhaack opened 6 years ago

edhaack commented 6 years ago

First: Thank you @PeteGoo for one of my staple TC Plugins! I've used it for several years now, without problem... until I changed jobs, and put it on a TC box running 2017.1.3 (an earlier version than I was using at my previous location - and it was working fine): Version 1.4.4 (I know I even tried the latest version, 1.4.6, same results...)

Succeeded link works. Running link is wonky. Very weird.

I've checked the log for the request being made to Slack. Both the request made for the Running and Succeeded are the same (aside from the message text) as far as the link it concerned:

Running - Text Value:

&text=%3Chttp%3A%2F%2Fdev034.######.org%3A8111%2FviewLog.html%3FbuildTypeId%3D######10_######Sys_SysWeb%26buildId%3D660%7CRunning+-+######1.0+%3A%3A+######+%3A%3A+Sys+-+Web.DocLib+%231.3.8-%3Cdefault%3E%3E &pretty=1 using proxy null:0

Succeeded Text Value:

&text=%3Chttp%3A%2F%2Fdev034.######.org%3A8111%2FviewLog.html%3FbuildTypeId%3D######10_######Sys_SysWeb%26buildId%3D660%7CSucceeded+-+######1.0+%3A%3A+######+%3A%3A+Sys+-+Web.DocLib+%231.3.8-build%3E &pretty=1 using proxy null:0

This is what shows in the Slack Channel (instead of just "Running" w/ the link:

<http://########.org:8111/viewLog.html?buildTypeId=########_ID&buildId=660%7CRunning - ######## :: ########:: ######## #1.3.8->

Thoughts?

amir-najjar commented 6 years ago

I did not see anywhere where you can set the configuration base link, so I think it's a bug which started occurring on newer releases of TeamCity

edhaack commented 6 years ago

What's odd is... I'm using just one minor release/version older of TeamCity that I knew it was working on.

It may actually be with Slack itself. Handling of <http://url.com|text here> syntax doesn't always work correctly. Example: <http://www.google.com|google>

Unless I'm missing something.