Added Overlay if recently read by TTS

Peterodox / YUI-Dialogue

World of Warcraft Dialogue UI Add-On

https://www.curseforge.com/wow/addons/dialogueui

24 stars 7 forks source link

Added Overlay if recently read by TTS #53

Closed BelegCufea closed 2 months ago

BelegCufea commented 2 months ago

Hi again,

I see you're adding a brand-new Quest Popup feature, so you might have missed my suggestion about adding an overlay to clearly indicate when dialog text has recently been read.

I’ve “borrowed” one of your icons, somewhat haphazardly slapped it over the speaker icon, and made it visible when TTS should play but is blocked by the recently-read logic.

It might look awful right now (as I have a negative artistic taste), but here it is in action :-)

Feel free to dismiss this PR—it's just me nagging you again (sorry!).

Peterodox commented 2 months ago

Hi! I don't think there is a good solution right now for notifying users of skipped dialogue. This icon is too small, and using a pop-up or even literally telling the user that the dialogue has been skipped can be intrusive. I'll leave it be for now. We'll react when or if it becomes a common issue.

By the way, did you recently make a Pathfinder Wrath of the Righteous TTS mod? I'm writing a post on Twitter and want to credit you.

BelegCufea commented 2 months ago

Not really. If you are thinking this https://github.com/Osmodium/PathfinderTextToSpeechMod, then I just nagged the author to add 4 lines of code to be compatible with Natural Voices. Just made two small ones for WoW :-)

Anyway, thanks for considering this PR. I know you will introduce better solution if occasion arise.

Have a nice day.