pyOpenSci Initial Updates and Upgrades

PetroFit / petrofit

Python package for calculating Petrosian properties and fitting galaxy light profiles

https://petrofit.readthedocs.io

26 stars 6 forks source link

pyOpenSci Initial Updates and Upgrades #205

Closed robelgeda closed 7 months ago

robelgeda commented 7 months ago

List of updates based on pyOpenSci review

[x] The package should install without the use of requirement.txt:
- [x] Matplotlib was missing, I have added it.
- [x] New versions of astropy no longer need update_default_config. I have removed this function call for people using pip to install.
[x] Add zenodo badge (I see one on the Citing and Credits) page in docs to README.md
[x] Clean up docstrings in models.py
[x] Update pip install instructions
[x] Clean up ci_test.yml

SterlingYM commented 2 months ago

These changes seem to solve some problems with the compatibility of the up-to-date Astropy version when tested with a clone of the current main branch, but the latest release of Petrofit on PyPI is outdated and does not include these changes. Could you release the current main branch and update the pip-installable version? This will help quite a lot when using Petrofit as a requirement for other packages. Thanks!

robelgeda commented 2 months ago

Absolutely! I will work on python compatibility issues next two weeks and release whatever I we have ready. Thank you for letting us know!!

robelgeda commented 1 month ago

@SterlingYM I have released a minor version with the changes!