PetrochukM / PyTorch-NLP

Basic Utilities for PyTorch Natural Language Processing (NLP)

https://pytorchnlp.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.21k stars 258 forks source link

Update logo to the new style of PyTorch 1.0 #28

Closed floscha closed 6 years ago

floscha commented 6 years ago

This PR simply updates the PyTorch-NLP logo to align more with the new style of PyTorch.

codecov-io commented 6 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          56       56           
  Lines        1614     1614           
=======================================
  Hits         1528     1528           
  Misses         86       86

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fda5b6...4321712. Read the comment docs.

PetrochukM commented 6 years ago

Hi There!

Thanks so much for your effort in creating this Logo! I like the idea. The previous logo was created by a professional designer. I'm going to ask her to review your logo and maybe suggest a couple changes.

This might take awhile, she's pretty busy this next two weeks.

Thanks!

PetrochukM commented 6 years ago

Hi There!

Updated the logo with Chloe Yeo's work. She felt your idea had a lot going for it. Taking into account the new letter style of Pytorch 1.0. She also felt the boxy look didn't suit the new PyTorch 1.0 logo.

Sent a commit with her iteration on top of your work to the branch.

Thanks!