Ujson reliance doesn't permit successful install

PetrochukM / PyTorch-NLP

Basic Utilities for PyTorch Natural Language Processing (NLP)

https://pytorchnlp.readthedocs.io

BSD 3-Clause "New" or "Revised" License

2.21k stars 258 forks source link

Ujson reliance doesn't permit successful install #49

Closed dspoka closed 5 years ago

dspoka commented 6 years ago

Expected Behavior

Having trouble installing this due to not being able to install ujson. As I understand ujson is faster than json but has issues on different pythons. for example: https://github.com/jjjake/internetarchive/issues/14

Steps to Reproduce the Problem

My system

import sys
print(sys.version)
3.6.3 |Anaconda custom (64-bit)| (default, Oct 13 2017, 12:02:49)
[GCC 7.2.0]

pip3 install py pytorch-nlp

AtmaHou commented 6 years ago

I happened to solve it by installing the newest version of VS studio, but it re-occurs now. hoping for a solution for it.

PetrochukM commented 5 years ago

Sorry guys! Removed ujson from the code base since it's such a hassle. Please reinstall and it should be okay.