Pexeus / LCSS

CSS editor
51 stars 11 forks source link

setting up constants etc. #8

Closed tomasvn closed 4 years ago

tomasvn commented 4 years ago
tomasvn commented 4 years ago
Pexeus commented 4 years ago

yes, i have seen that before, i think i its because i have the imports in multiple files. Would it be a good idea to create a "import.js" file, with all the imports?

tomasvn commented 4 years ago

yes it would be a good idea, it would probably create cleaner code, because you seem to be settled on es6, but when you try to use those es6 features it breaks your code, I am not that good with es6 but this seems to a be a good idea to implement exporting modules and somehow combine it into one file that you will load in <script src="..."></script>

tomasvn commented 4 years ago

See #9

Pexeus commented 4 years ago

Yo dude, first, thanks so much for all the work on the setup, it looks so clean now! To be honest. i dont even now what "ES6" is, (you have to keep in mind, all my JS knowledge is googling stuff xD). but i understand the way u made things work in the setup scripts, and i really see the advantages. I think taking a similar approach on the editor would be great, but right now, im focused on some other things including:

I have now created an "experimental" branch, i hope thats what u needed!

tomasvn commented 4 years ago

😄 oh, i tought that you know some es6 because you where using let, const, arrow functions etc

Pexeus commented 4 years ago

i think i just used the stuff i found online... What do you think about the code in general? what mistakes did i made?

tomasvn commented 4 years ago

i see...it was ok, you have to use const and let more, read about them, you just left them without setting proper const, eg. fs = require(fs) this is bad, it might result in errors, you have to declare variables

tomasvn commented 4 years ago

I might rework the editor script part, I will try to debug the code, but there is more code than in the setup part, issue is resolved, I am closing this issue