search

Phalcode / gamevault-app

Frontend for the self-hosted gaming platform for drm-free games
https://gamevau.lt
Other
398 stars 18 forks source link

News icon always shows exclamation point on startup #450

Open kjack9 opened 3 weeks ago

kjack9 commented 3 weeks ago

Describe the bug The News icon in the bottom left bar always shows the "new news" exclamation point on startup, even if there is nothing new. The exclamation point goes away after clicking the icon, but re-appears the next time the app is restarted.

To Reproduce Steps to reproduce the behavior:

  1. Close app
  2. Open app
  3. Observe exclamation point
  4. Click news icon and observe exclamation point disappearing
  5. Close app
  6. Open app
  7. Observe exclamation point

Expected behavior Exclamation point should only show if there is new news

Screenshots image

Desktop (please complete the following information):

Additional context N/A

Alfagun74 commented 3 weeks ago

Are you absolutely sure nothing changed?

The exclamation mark should only be visible if either GameVault News or Server News have changed.

@Yelo420 how do we the save news state?

Yelo420 commented 3 weeks ago

That’s strange. The news state is saved by creating a hash of the 'GV News' and 'Server News' and comparing it with the previous one. @kjack9, if you’re sure that nothing has really changed, could you take a look at the server message and let me know if there are any special characters, or if it’s empty? I’m looking for any specific cases that could be causing this.

kjack9 commented 3 weeks ago

That’s strange. The news state is saved by creating a hash of the 'GV News' and 'Server News' and comparing it with the previous one. @kjack9, if you’re sure that nothing has really changed, could you take a look at the server message and let me know if there are any special characters, or if it’s empty? I’m looking for any specific cases that could be causing this.

100% sure since I don't have a server message set. The "GameVault News" tab shows the initial message -- "Welcome to the new GameVault news section!". My "Server News" is blank as I haven't set it up with anything.

Also note that there is sometimes a delay before the exclamation point shows up again -- a few hours ago I closed and re-opened, and it wasn't there. Checked again just now, and it's back.

Yelo420 commented 3 weeks ago

Hi @kjack9 we are not able to reproduce this problem. Would it be possible to provide us a guest account, so we can look deeper into this? Write to contact@phalco.de. Else i can send you a modified GameVault version, that shows us exactly the changes.