Phil1988 / FreeDi

LCD firmware for Qidi X-3 Series printers with mainline Klipper
Other
99 stars 3 forks source link

[Joke] Borat Fan #99

Closed ohyeah8000 closed 2 weeks ago

ohyeah8000 commented 2 weeks ago

In your config section you describe a Broad Fan ;) [heater_fan borad_fan]

Please spell it correctly. Borat is written with a T!

Source:

https://github.com/Phil1988/FreeDi/wiki/Post-install-and-config-section

MarkusKgit commented 2 weeks ago

Not a bug, that's just a reference to the original wrong spelling in the official Qidi config (most likely they meant Board Fan). The section in the wiki is therefor correct. In the FreeDi config its named MCU_fan

theclue commented 2 weeks ago

I think he is ironic btw :D

Image

Phil1988 commented 2 weeks ago

@ohyeah8000 Thank you for your comment. Just to clarify, are you being serious about this suggestion, or was it meant as a joke?

I want to ensure I address the report appropriately.

ohyeah8000 commented 2 weeks ago

Of course it's a joke! 😃

But the same time I'm serious and pointed out a little misspelling in your final modified printer.cfg to make it better. Board_fan it has to be of course...

image

Phil1988 commented 2 weeks ago

Thank you for your input!

However, I’d like to kindly remind you that bug reports should focus on genuine issues related to the project. Jokes or unrelated comments can make it harder to efficiently address real problems and take up valuable time.

I’m totally open to jokes, but I’d really appreciate it if you could place them anywhere else (like Discussions, Discord,...).

Thank you for your understanding, and I look forward to receiving more valuable feedback from you in the future!