PhilippC / keepass2android

Password manager app for Android
https://play.google.com/store/apps/details?id=keepass2android.keepass2android
GNU General Public License v3.0
4.87k stars 393 forks source link

Availability through f-droid? #38

Open natrius opened 7 years ago

natrius commented 7 years ago

Is it possible to make it available via f-droid or is there a reason its not there? As its open source it should be possible.

If not, it should be possible via a custom repository for keepass2android so its available for users without google play store https://f-droid.org/docs/Setup_an_F-Droid_App_Repo/

greets

firecat53 commented 7 years ago

There has been a packaging request on F-Droid's Gitlab site. Maybe someone can help out @PhilippC with the licensing questions?

nougad commented 7 years ago

I think that's the policy for submitting to f-droid: https://f-droid.org/wiki/page/Inclusion_Policy

It links to the gnu.org list of licenses: https://www.gnu.org/licenses/license-list.html . As far as I understand all GPLCompatibleLicenses and GPLIncompatibleLicenses are fine.

ishitatsuyuki commented 7 years ago

@PhilippC: I think the best option is to disable all proprietary things through a F-Droid build flavor. It should be the de-facto standard, and one example is riot-android.

Just by the way, Syncthing is comfortable.

PhilippC commented 7 years ago

I have created an fdroid branch which should resolve the licensing issues. For updates, please refer to https://gitlab.com/fdroid/rfp/issues/5

CryptGoat commented 7 years ago

Looking forward to the F-Droid release! :)

DJCrashdummy commented 7 years ago

@PhilippC will the fdroid-build have entirely the same features as the master?

if not - or as a quick workaround, since it isn't completely done for now - please release an apk at github/gitlab. i'm sure @IzzySoft will be so kind to pick it up and add to his F-Droid Repository.

IzzySoft commented 7 years ago

If it's a build different from F-Droid, it should preferably have a different package name then to avoid confusion. But yes, feel free to ping me then.

ishitatsuyuki commented 7 years ago

Presumably proprietary file syncing features are removed, and that should be the only difference.

DJCrashdummy commented 7 years ago

@ishitatsuyuki for sure all proprietary parts won't be included in an fdroid-version, but what specific features will be affected...?

ishitatsuyuki commented 7 years ago

Most file syncing platforms.

DJCrashdummy commented 7 years ago

...so the nonet-version may be identical and easier to publish via f-droid?

natrius commented 7 years ago

Hm, if you don't want to hassle much around it would be possible to set up your own repo for f-droid: https://f-droid.org/docs/Setup_an_F-Droid_App_Repo/ You may consider it, you don't have to change anything at the app itself. And everybody gets updates if you update it. But via the f-droid repo would still be wonderful : D

DJCrashdummy commented 7 years ago

@natrius that's why i asked in https://github.com/PhilippC/keepass2android/issues/38#issuecomment-341652382 to publish an apk-file which can be included into an own repo.

natrius commented 6 years ago

Is there an update? Or is there even the possibility to download the .apk ?

alexanderadam commented 6 years ago

@natrius the apks are still on the releases page and the app is still not on F-Droid.

You could save other people's time, simply by reading and clicking.

IzzySoft commented 6 years ago

@alexanderadam that RFP is still stalled, so the app itself is not on F-Droid yet.

alexanderadam commented 6 years ago

@IzzySoft I know. That's the reason why I wrote that it is still not available and linked to that rfp. :wink:

IzzySoft commented 6 years ago

Ouch, I missed 3 letters in that link: "not" :scream: Apologies!

alexanderadam commented 6 years ago

It's somehow a pity. There are a some really good KeePass clients like keepass2android and keepshare that are open source bot not on F-Droid yet. Currently I'm using KeePassDX because it looks more modern than keepassdroid.

Is there any client I could have missed?

IzzySoft commented 6 years ago

@alexanderadam keepshare hasn't been updated for more than a year now (last commit was in 6/2017, last release in 2016). TinyKeePass is at F-Droid as well.

If you follow the RFP for Keepass2Android you will find that @PhilippC and I are working to get it into my repo at least, but that might take a little (Philipp might be able to give an ETA).

IzzySoft commented 6 years ago

@alexanderadam @natrius @DJCrashdummy @CryptOwl finally it's available in my repo (since July 9th).

alexanderadam commented 6 years ago

But still not in the official repos. :cry:

DJCrashdummy commented 6 years ago

@IzzySoft thank you very much! definitely an improvement. do you think is it somehow possible to get the add-ons into a repo - at least into yours, as long as they are also not in the main one?

IzzySoft commented 6 years ago

@DJCrashdummy hard to say, as most of the linked ones don't have APKs in their repos. And the other 2 (K2AUSBKeyboard and AutoFill Plug-in) are already in my repo :wink:

DJCrashdummy commented 6 years ago

@IzzySoft i knew about the K2AUSBKeyboard but somehow missed the AutoFill Plug-in... :confused: i'll take this as an ok from your side as soon as we get some APKs. :wink:

IzzySoft commented 6 years ago

@DJCrashdummy you didn't mention the first (but had me check! evil, evil :rofl:) – and couldn't have seen the second as I adopted that only after your previous comment was posted. And you can take that as a "not OK as long as there are no APKs" – though I'll probably take them in when they're there; but wouldn't it be better to file an RFP with the official repo first? If they accept and build it, there'd be no reason for Philipp to provide APKs in his repos.

nazar-pc commented 5 years ago

Any news on pushing this app to F-Droid eventually? I'd rather install it from F-Droid than from Google Play.

IzzySoft commented 5 years ago

@nazar-pc it's currently available in my repo – but I agree it should be in the official one. The reason why it isn't can be found here: it's a Xamarin app, and would need an F-Droid team member with Xamarin experience to build…

shyney7 commented 4 years ago

Still no progress?

rakshazi commented 4 years ago

Hello, Could you add some kind of tl;dr about current f-droid status to readme, please? I see that issue got duplicated multiple times and people asking for updates, so it will be easier for all to find that information in readme.

BTW, link to @IzzySoft repo in readme is good idea, too

IzzySoft commented 4 years ago

There's even a badge available for that :wink:

jokay commented 4 years ago

🙈

After almost 3 years, the switch to KeePassDX seems a good advice 😉

keunes commented 3 years ago

@x-jokay I tried out KeePassDX but unfortunately it seems I cannot set up a WebDAV database for easy synchronisation with my Nextcloud instance.

I tried TinyKeepass also but it doesn't allow editing. So I'll stick to Keepass2android through Google…

And we can't blame KP2A developers for F-Droid not being able to handle the code so I'm inclined to keep supporting/using the best app I know of.

KopfKrieg commented 3 years ago

KeePassDX but unfortunately it seems I cannot set up a WebDAV database for easy synchronisation with my Nextcloud instance.

FYI: If you have Nextcloud installed on your phone you can select the database like a normal file. Nextcloud will handle the synchronization for you then.

keunes commented 3 years ago

FYI: If you have Nextcloud installed on your phone you can select the database like a normal file. Nextcloud will handle the synchronization for you then.

True, but it wouldn't be able to handle conflicts and gracefully merge the two versions of the database. Also I don't need to send back and forth the whole database file when I correct a simple typo. Using WebDAV has its advantages :)

mathstuf commented 3 years ago

Not sure how WebDAV would (meaningfully) merge encrypted files, but OK :) . It could hold different versions, but any merge conflicts is going to be manual (though possibly mediated through a smart enough client, but that wouldn't care about WebDAV versus local filesystem either).

ccoenen commented 3 years ago

The root cause appears to be Xamarin, more specifically how to build it one a buildserver. That problem with F-Droid is tracked here: https://gitlab.com/fdroid/fdroiddata/-/issues/1529

mottech20 commented 2 years ago

I recently started using this app. Works like a charm.
I just wanted to ping this thread to remind how wonderful it would be if it was available on F-droid. Can we give it a push?

IzzySoft commented 2 years ago

@mottech20 the problem is rather that F-Droid cannot build Xamarin apps yet (see the comment right on top of yours). It's being worked on, but with the entire team being volunteers and not enough hands for all tasks waiting to be tackled, that might take time.

Offerel commented 2 years ago

Hopefully, it will be available soon on F-droid or at least by Izzys repo. I could not find it there

bege10 commented 1 year ago

@IzzySoft Would you mind adding this full and maintained app to your repo? Thanks.

IzzySoft commented 1 year ago

@bege10 it is in my repo (the "nonet" variant). Just not the latest release, as the APK there is unsigned (I've already pinged Philip on that from a different issue). The "full" variant is beyond the per-app size limit of my repo. Should "per-ABI builds" be provided (one APK per architecture, like armeabi, arm64, x86, x86_64) the APK size for each would fall below 20 MB and I could consider that, too. But a non-free dependency (here: Google Services) with an app dealing with sensitive details (passwords) AND network permissions (no offense meant, but with Google's stuff you can never be sure what it's doing behind the curtains, and you cannot check if its proprietary without the full code base open) rather not.

bege10 commented 1 year ago

@IzzySoft Thank you, I totally agree. The nonet variant is so old that it looked like not being maintained any more. If it were a current release it will be absolutely fine for me.

IzzySoft commented 1 year ago

There were build issues with the nonet variant. And yes, it just needs @PhilippC to replace the APK by a signed one and give me a ping, then it would be updated in my repo on the very next day.

ltguillaume commented 1 year ago

@PhilippC I wish there were a WebDAV-only version, instead of a NoNet version. WebDAV is widely available and inclusion wouldn't require any proprietary libraries. Inclusion on Izzy wouldn't be an issue either.

IzzySoft commented 1 year ago

@ltGuillaume when it comes to password safes, I prefer them to not have network permissions. That way the app dealing with the plain-text passwords and doing the encryption cannot send them out – and the app dealing with the sync of the database cannot peek in. Keepass2Android already has some proprietary components in, which is what ruled it out for my personal use but is kind of gray area for my repo. Add network, and the gray becomes pretty dark. I fully trust @PhilippC here, but he cannot vouch for what those proprietary parts (which after all come from Google, the big data collector) might be up to.

So with the non-free components gone, having WebDav in (and thus requiring network permission) would be OK for my repo, yes. But as I don't know why those are needed I cannot tell if they can be removed easily (or what might have dragged them in).

ltguillaume commented 1 year ago

I'm thinking there may be merge issues when using the Nextcloud app for syncing, as opposed to letting Keepass2Android handle it via WebDAV. But I might be wrong about that, and it could be that Keepass2Android just overwrites the local database with a newer from the remote location, without merging the two (as Keepass2 does). Perhaps @PhilippC can shed some light on this?

nazar-pc commented 1 year ago

Nextcloud app is really bad on Android, I wouldn't recommend it on a phone for anything, it is simply not reliable (DavX5 mount works fine though). But in the end it is just WebDav, which I use for years with great success and Keepass2Android does suggest merging if remote was changed in the meantime when using WebDav.

ikanakova commented 11 months ago

There will probably never be an app on F-Droid / F-Droid custom repo, right? A custom repo like NewPipe's would be really cool.

bege10 commented 11 months ago

There will probably never be an app on F-Droid / F-Droid custom repo, right? A custom repo like NewPipe's would be really cool.

The Offline version is available in Izzy's custom repo.