Philippus / elastic4s

🔍 Elasticsearch Scala Client - Reactive, Non Blocking, Type Safe, HTTP Client
Apache License 2.0
1.64k stars 695 forks source link

Rank feature query function typing fixes #3160

Closed jurgisnosto closed 2 months ago

jurgisnosto commented 2 months ago

Description

This PR fixes incorrect typings in rank feature saturation, sigmoid and log query functions. More specifically, pivot and scaling_factor fields should accept floats instead of integers. This can be confirmed for each function:

Official docs can be found here.

Context

The error was encounter while migrating from the deprecated high level rest client to elastic4s. We are using saturation function with float values which cannot be changed, so the migration is on hold until the PR is merged. Please let me know if you need any additional input from me

Philippus commented 2 months ago

Nice catch! I think the examples threw me off, as they only show whole numbers.