Fix open and import of some PDF file cases

PhilterPaper / Perl-PDF-Builder

Extended version of the popular PDF::API2 Perl-based PDF library for creating, reading, and modifying PDF documents

https://www.catskilltech.com/FreeSW/product/PDF%2DBuilder/title/PDF%3A%3ABuilder/freeSW_full

Other

6 stars 7 forks source link

Fix open and import of some PDF file cases #209

Open PhilterPaper opened 5 months ago

PhilterPaper commented 5 months ago

Per ssimms/pdfapi2/pull/28, @xazzzz suggested changes to API2.pm (Builder.pm) and Basic/PDF/Dict.pm to check some things that caused errors. I have put the small change in Builder.pm, but before I copy over sub find_prop() from Basic/PDF/Page.pm into Basic/PDF/Dict.pm, it would be nice to know if PDF::Builder suffers from this same problem. A complete test case was not given, so I can't test it.

@draxil added some comments, so perhaps they have some useful information.

PhilterPaper commented 5 months ago

There were references to RT 130722 (rejected) and RT 131147 (fixed/closed), as well as ssimms/pdfapi2/pull/21 (closed).

PhilterPaper commented 1 month ago

Note to self: need to go exploring and find (internal) uses of find_prop(). Is it possible that Dict.pm doesn't see the one in Page.pm under some circumstances? (or something built through Dict that doesn't have Page as an ancestor?) If so, that would warrant duplicating the method.