Phobos-developers / Phobos

Ares-compatible C&C Red Alert 2: Yuri's Revenge engine extension
GNU Lesser General Public License v3.0
300 stars 95 forks source link

Customizable Bars of Health Points #1395

Open Fryone opened 1 month ago

Fryone commented 1 month ago

Added customizable health bars in form of BarTypes. By default, technos use their own vanilla healthbars. Adding HealthBar.BarType changing health bar to this type. Can be applied to buildings.

Example

[BarTypes]                           ; section in rulesmd.ini
0=HEALTHBAR1

[HEALTHBAR1]
BoardBG.File=                        ; filename - without the .shp extension, image for use as background, first frame
BoardBG.ShowWhenNotSelected=false    ; boolean, should background be drawn, when ponting on techno
BoardBG.Translucency=                ; translucency level (0/25/50/75), background image translucency level
BoardFG.File=                        ; filename - without the .shp extension, image for use as foreground (drawn after health sections), first frame
BoardFG.ShowWhenNotSelected=false    ; boolean, should foreground be drawn, when ponting on techno
BoardFG.Translucency=                ; translucency level (0/25/50/75), foreground image translucency level
Board.Offset=0,0                     ; X,Y, offset of background and foreground boards images
Bar.Offset=0,0                       ; X,Y, offset of whole bar
Sections.DrawBackwards=false         ; boolean, changes order of drawing from last to first
Sections.EmptyPip=-1                 ; integer, frame in pips.shp to use for empty section
Sections.Pips=16,17,18               ; list of 3 integers, frames of pips.shp to use (green, yellow, red states)
Sections.Amount=17                   ; integer, amount of sections, when bar is full
Sections.PositionDelta=2,0           ; X,Y, increment in pixels to next section

[SOMETECHNO]
HealthBar.BarType=HEALTHBAR1

No docs for now, needs testing. image

github-actions[bot] commented 1 month ago

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

tyuah8 commented 1 month ago

Added customizable vertical health bars in form of HealthBarTypes. By default, technos use their own vanilla healthbars. Adding CustomHealthBarType changing health bar to this type. Can be applied to buildings.

Example

[HealthBarTypes]                                                       ; section in rulesmd.ini
0=HEALTHBAR1

[HEALTHBAR1]
Frame.Background=PIPBRD                                      ; shp file for use as background, first frame
Frame.Background.Translucency=0                           ; background translucency level
Frame.Background.ShowWhenNotSelected=false    ; should background be drawn, when ponting on techno
Frame.Foreground=                                                   ; shp file for use as foreground (drawn after health sections), first frame
Frame.Foreground.ShowWhenNotSelected=false     ; should foreground be drawn, when ponting on techno
HealthBar.OffsetX=0                                                  ; horizontal offset, similar to PixelSelectionBracketDelta
Sections.Pips=16,17,18                                              ; frames of pips.shp to use (green, yellow, red states)
Sections.Amount=17                                                 ; amount of sections, when bar is full
Sections.Size=2                                                          ; size in px of individual section

[SOMETECHNO]
CustomHealthBarType=HEALTHBAR1

No docs for now, needs testing. image

Those voxels are quite nice and seem to resemble the look and feel of the original game voxels. Did you make those voxels yourself?

Fryone commented 1 month ago

Those voxels are quite nice and seem to resemble the look and feel of the original game voxels. Did you make those voxels yourself?

yep

NetsuNegi commented 1 month ago

nice feature for epic vehicle/airship/battleship :)

Metadorius commented 1 month ago

image Custom Health Bar

Metadorius commented 1 month ago

Couple of suggestions on the general API stuff: [HealthBarTypes] => [BarTypes] In general I propose to treat this as a "custom anything bar" which can be used for HP bars.

For technos the tag should be CustomHealthBarType => HealthBar, less redundancy and more in-line with other things.

I think shields should use that too.

Metadorius commented 1 month ago

P.S. Can you do any shape/direction bars this way? I think it's a matter of making the section offset customizable in two dimensions, this way you could specify the 2,2 offset and have the bar go diagonal for example.

Fryone commented 1 month ago

P.S. Can you do any shape/direction bars this way? I think it's a matter of making the section offset customizable in two dimensions, this way you could specify the 2,2 offset and have the bar go diagonal for example.

The horizontal (vanilla like) bars were first in mind. I understand vertical ones, but diagonal...

Metadorius commented 1 month ago

The horizontal (vanilla like) bars were first in mind. I understand vertical ones, but diagonal...

It's only an example. The point is that if one can specify offset between sections in 2 dimensions then they can come up with whatever weird graphics they want, including diagonal bars, sectioned graphics etc.

Fryone commented 1 month ago

I think, I probably should make some "BarMaker" then, like procedure to draw by position and type.

chaserli commented 1 month ago

1287 #1309 #1395

https://github.com/Phobos-developers/Phobos/pull/1287#issuecomment-2198477945 If you are making a bar, generalize it to cover all fractionable quantities. HP/SP are just a small part of them. Some should display regardless of mouse hovering/selected.

Fryone commented 1 month ago

1287 #1309 #1395 #1287 (comment) If you are making a bar, generalize it to cover all fractionable quantities. HP/SP are just a small part of them. Some should display regardless of mouse hovering/selected.

yeah, so the bars can be used to draw without hovering/selecting. i'm just using bar-drawer in the vanilla health part code. So it behaves like vanilla health bar.

chaserli commented 1 month ago

yeah, so the bars can be used to draw without hovering/selecting. i'm just using bar-drawer in the vanilla health part code. So it behaves like vanilla health bar.

I mean you can go more aggressive than that, just replace all 4 DrawHealthBar vtbl calls and handle it as well as other things in drawextras.

ZivDero commented 1 month ago

Also, you're hooking into the function. But the vanilla function is just one big if-else, and you hook both of the branches. You should replace the entire function.

Additionally, your hooks disable other Phobos hooks (shield bars, HeathBar.Height, digital displays). As such, you should move those patches into your replaced function, too.

Metadorius commented 1 week ago

@Fryone is there anything blocking you from fulfilling the requested changes?

Fryone commented 1 week ago

@Fryone is there anything blocking you from fulfilling the requested changes?

Nothing, I just need to get it. I just need to do it.