[Minor] Clear jumpjets' redundant destination

Phobos-developers / Phobos

Ares-compatible C&C Red Alert 2: Yuri's Revenge engine extension

GNU Lesser General Public License v3.0

300 stars 95 forks source link

[Minor] Clear jumpjets' redundant destination #1408

Closed CrimRecya closed 3 weeks ago

CrimRecya commented 1 month ago

Clear jumpjets' redundant Destination when they change state to hovering. This is for improving align jumpjet turret's facing with body's, and adapt to #1308 .

github-actions[bot] commented 1 month ago

Nightly build for this pull request:

compiled-dll-ebf7298710360abc6c728c93d12a40a448e70137.zip These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

CrimRecya commented 3 weeks ago

I'm not sure about this, force queuing guard mission without target check seems a bit radical and I already observed something a bit weird. That comment of mine was made 2+ years ago and I somehow doubt it now, I may need some explanation/confirmation.

I have removed unnecessary queue guard mission. Everything I have done here is just to clear the jumpjet's Destination when it has arrived at its destination, just like others.

Metadorius commented 3 weeks ago

Why was the PR closed?

CrimRecya commented 3 weeks ago

Why was the PR closed?

Oh, actually, I just learned about a phenomenon about some jumpjets that cannot attack while moving will get stuck in the move mission without destination and allow enemies to pass underneath them. I haven't thought of any good solutions yet.