PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

[REQ] Font sizes have shrunk #289

Closed maggieer closed 4 months ago

maggieer commented 5 months ago

Is your feature request related to a problem? If so, please describe. After pulling the three most recent commits (from 3/15 and 3/16), the font in a number of windows and buttons is super small compared to before (maybe 4 pt), which makes it very hard to read. Not sure if this is the case on other devices as well. Maybe this has something to do with the updates to mainwindow.py ?

Describe the solution / new feature you'd like It would be great to get the font size back to the same or similar size as in the window headers (10 or 11 pt?)

Describe any alternatives you've considered Longer term, a way to change font size or zoom in/out would be helpful (see issue #47).

Additional context OS: Windows 11 Home Version 10.0.22621 SLP-AA main branch, most recent push as of 3/19

fontsize_03_19_handshape This first image spans the width of my screen. fontsize_03_19_location fontsize_03_19_movement fontsize_03_19_relation fontsize_03_19_signlevel fontsize_03_19_signtype fontsize_03_19_xslot

kchall commented 5 months ago

@kvesik Can you take a look at this one? Thanks!

kvesik commented 5 months ago

Thank @maggieer ! I was running into the same thing but assumed it was due to my laptop/monitor display relationship (which sometimes causes weird resolution issues). But you're right; I see that different types of font throughout the software are at varying sizes, which is... not great.

kvesik commented 5 months ago

@maggieer @kchall main branch has now been updated with a Font Size setting in the Preferences Menu / Display tab. I've set the default to 8, as that's what seemed to be most reasonable with various resolution/text sizing options on my computer.

The settings doesn't quite affect all fonts in SLP-AA (eg the text in the module boxes in the visual summary doesn't change), but most of the rest of it works pretty nicely. And in particular, I think it deals with all the spots that suddenly had super-tiny font recently.

kchall commented 4 months ago

I think this is basically great; very nice to be able to specify it manually. Font size 12 is a pretty close match to what I used to get by default on my Mac. One side issue though now is that when I increase to size 12, not all the text fits on the button menus.

Here's a screenshot of the "old" version, before font size was manipulable. Note that all of "Add hand configuration module" is visible on the relevant button:

image

Here's a screenshot of the "new" version, with font size at the default of 8 pt. All text fits on the buttons, but is overall too small for comfort:

image

Then if I switch it to 12-point font, this is more comfortable on the eyes, but now not all the text fits:

image
kvesik commented 4 months ago

OK! I will look into whether there's a nice way to help the buttons and other widgets expand along with the text.

kvesik commented 4 months ago

@kchall upon further inspection it appears that the buttons will resize correctly the next time you close/reopen the software. Can you please confirm whether this works for you?

I have done a bit of looking into whether there's a way I can convince the buttons to resize themselves on the fly but it's turning out to be surprisingly trickier than I would have expected :/

kvesik commented 4 months ago

@kchall upon further inspection it appears that the buttons will resize correctly the next time you close/reopen the software. Can you please confirm whether this works for you?

I have done a bit of looking into whether there's a way I can convince the buttons to resize themselves on the fly but it's turning out to be surprisingly trickier than I would have expected :/

@kchall just following up on my question above :)

kchall commented 4 months ago

Yes! Looks like they are re-sized -- cool, thanks!

kvesik commented 4 months ago

PR #305 adds a warning to users that some font-size changes won't take effect until SLPAA is restarted