search

Phr33d0m / NW-Profession-Bot

Automatically selects professions for empty slots
12 stars 31 forks source link

Failed to collect rewards for assignment "Fight Off Spellplagued." Make sure that you have room in your inventory. #53

Closed noonereally closed 9 years ago

noonereally commented 9 years ago

Will love to see the script continue, and not get totally stuck in this state. Generally will happen with any 'producing' profession.

BigRedBot commented 9 years ago

That is a generic error and can happen if you have lag. Even if the reward is being collected. It happens to me sometimes. I just ignore it since the reward does get collected.

If it is getting stuck and not continuing, then that is another issue altogether.

RottenMind commented 9 years ago

Its quite common error.

I saw it first time few months ago, no stucks with it reported, just annoying error what leads "nowhere"...

Phr33d0m commented 9 years ago

Yeah, what @BigRedBrent said. I've said before that in my case I can easily reproduce the issue if I have torrents downloading or just high latency/lag for some reason... Not much we can do at this point unforunately.

Feel free to reopen if you do believe there's a fix for it.

noonereally commented 9 years ago

No, the inventory is really full. It's not a bug, at least the error itself, the only issue i saw is that the script doesn't fall back and allocate the rest of the slots and move on, instead it get stuck on trying to collect the rewards, obviously not possible because the inventory is still full. Or you mean it shouldn't get stuck ? (I better check the code, but i do no remember anything that skips noncollectable slots)

RottenMind commented 9 years ago

oh, you mean that your inventory is "FULL" and you cant "Collect Rewards", only possible "simple" fallback for that is "auto Vendor" items before inventory became full... sell all but rank3.

If you leveling profession and use "Vendor/Maintain Prof Crafted Levelup Items" and still get "Inventory Full", then it is good check that "Vendor crafted" items list is updated,

https://greasyfork.org/en/scripts/7808-neverwinter-gateway-professions-robot , zero inventory full, all profession up lvl20, I used 24 slots bag for testing. Anyway those lists are messy, but they work.

Phr33d0m commented 9 years ago

@noonereally oh, I seem to haven't reached the 'inventory full' thing in the title. Same case though, as what @RottenMind said & also we shouldn't really deal with such user-issues so make sure you have enough free inventory for that (specially if you're leveling weaponsmith and all of the sort).

Of course we could try to detect such cases and just skip to the next character but... well, pull requests are always welcomed :-).

noonereally commented 9 years ago

well, I think if a single char has all tasks completed and collected except one, and this will stuck the script, for all chars (reloading will not help). And if some fallback possible (even timeout or retry count) for the collection part that will make it log the error and go on, it's worthwhile. (fallback in the code) I know the available solutions, I thought more in the direction of enhancement suggestion...

dlebedynskyi commented 9 years ago

'inventory full' does stops all task on char. I can confirm this. we can just try to fall back for task that maybe don't produce any inventory stuff for that char. Do you think if this is possible?

noonereally commented 9 years ago

should not get stuck now, please help testing and confirming.

noonereally commented 9 years ago

Need to take into account the not collected slots when reading the next job time, otherwise the script returns to the same char.

HenryLoenwind commented 9 years ago

BTW: Now with the delay I think I see that the bogus error messages come from the first collection try. In this case, I'd guess the URL-changing right before the collection might be the reason. Or, going one deeper, the fact that loadCharacter? loads the task view but doesn't update the URL...so processCharacter re-loads the task view when setting the right URL.

noonereally commented 9 years ago

I don't think the random errors on collect are related to the URL swap, but indeed it feels 'weird' that the model is loaded but the URL is not changed. I've added an URL change into loadCharacter https://github.com/Phr33d0m/NW-Profession-Bot/commit/8243c2630af6b9e95c1c47f5871d6a9f1ec64d58

To this issue, added a check for failed to collect slots https://github.com/Phr33d0m/NW-Profession-Bot/commit/fb3f085e1cb327e206147b081c689fe1b981b4d8 Hopefully it will fix it, if someone have full inventory and can test, it will be appreciated.

noonereally commented 9 years ago

Tested, works