[PATCH]: Add minimum size of files to cache

[GoogleCodeExporter]

Please see the attached patch :)

Original issue reported on code.google.com by Spook...@gmail.com on 14 Feb 2014 at 10:33

Attachments:

• mincache.patch

[GoogleCodeExporter]

This issue was closed by revision 0042569adc4a.

Original comment by nils.braden on 15 Feb 2014 at 2:00

• Changed state: Fixed

[GoogleCodeExporter]

Integrated with r0042569adc4a, can you please review it since I also added a 
conversion of values with the old unit and I reduced the length of the field to 
3 digits since 999 MB should be way enough for a single image...

Original comment by nils.braden on 15 Feb 2014 at 2:03

• Changed state: Started

[GoogleCodeExporter]

Okay I got it completely wrong. We leave the unit of both preferences as KB, 
only changed the internal default value. Thought we were changing the unit. 
Next try: r1076584650f1

Original comment by nils.braden on 15 Feb 2014 at 2:28

[GoogleCodeExporter]

Hey,

first of all, thanks for applying my patches! :)
It seems like I have do do some more tests because those small images aren't 
displayed anymore at all when setting the minSize >0 :(
That shouldn't happen actually, it was actually intended to just fetch images 
<minSize.
I'm not sure if I get to it before the weekend though.

Original comment by Spook...@gmail.com on 18 Feb 2014 at 6:44

[GoogleCodeExporter]

Did you test this with the latest changes from r6ec2e8e83b16? I had the same 
problem and fixed it by including only cached images in the JavaScript header.

Original comment by nils.braden on 18 Feb 2014 at 6:52

[GoogleCodeExporter]

Ah, that looks good. Thanks!
I'll test it during the next week.

Original comment by Spook...@gmail.com on 21 Feb 2014 at 11:44

[GoogleCodeExporter]

Hi,

I tested it for about 2 weeks now and it seems to work fine so far :)

Original comment by Spook...@gmail.com on 7 Mar 2014 at 11:07

[GoogleCodeExporter]

Original comment by nils.braden on 9 Mar 2014 at 8:39

• Changed state: Fixed