search

PicNet / XGBoost.Net

.Net wrappers for the awesome XGBoost library
51 stars 18 forks source link

Add DMatrix overload for single dim array #20

Closed mdabros closed 6 years ago

mdabros commented 6 years ago

Hi @PicNet ,

Thanks for creating this very nice wrapper for XGBoost in .Net!

I am interested in including XGBoost via this wrapper in my own ML project SharpLearning.

To avoid some unnecessary copying of the feature data, would you be willing to accept this pull request which adds a 1D overload to the DMatrix?

best regards Mads

mdabros commented 6 years ago

Hi @gatapia,

It seems you are in charge of handling pull requests for this repo, so I hope you can help me with accepting or rejecting this one :-).

best regards Mads

gatapia commented 6 years ago

Cool, thanks, will release nuget in a day or so