search

PicNet / XGBoost.Net

.Net wrappers for the awesome XGBoost library
51 stars 18 forks source link

Fix booster dispose #22

Closed mdabros closed 6 years ago

mdabros commented 6 years ago

Hi @gatapia ,

It seems that the Booster.Dispose() method called the wrong XGBoost free operation. XGDMatrixFree instead of XGBoosterFree.

This would cause memory issues when using the library with GPU and training multiple models. For instance when tuning hyper parameters.

Hope you will accept the fix. Best regards Mads

gatapia commented 6 years ago

Cool, thanks