PicNet / XGBoost.Net

.Net wrappers for the awesome XGBoost library
51 stars 18 forks source link

Issue with nuget package #24

Closed mdabros closed 6 years ago

mdabros commented 6 years ago

Hi @gatapia ,

I am having an issue with the nuget package when used as a dependency for another package. It seems that nuget tries to add the native dll as a reference for the targeted project:

image

To avoid nuget trying to do this, you can add the following to your .nuspec file:

<references>
   <reference file="XGBoost.dll" />
</references>

This will tell nuget that the XBoost.dll is the only dll to reference during install. I tried this locally by modifying the PicNet.XGBoost.Net package, and it solves the issue.

Could you release a new version of the nuget package with this added to the .nuspec file? It would help me a lot since currently my own package doesn't work because of this issue.

best regards Mads

gatapia commented 6 years ago

Hi Mads,

I've updated the NuGet package and it installs, have not tested the functionality though. Will update the test project later today.

Cheers,

Guido

On 21 May 2018 at 17:38, Mads Dabros notifications@github.com wrote:

Hi @gatapia https://github.com/gatapia ,

I am having an issue with the nuget package when used as a dependency for another package. It seems that nuget tries to add the native dll as a reference for the targeted project:

[image: image] https://user-images.githubusercontent.com/9001637/40295511-d373857c-5cd9-11e8-88da-7605e0dd7e86.png

To avoid nuget trying to do this, you can add the following to your .nuspec file:

This will tell nuget that the XBoost.dll us the only dll to reference during install. I tried this locally by modifying the PicNet.XGBoost.Net package, and it solves the issue.

Could you release a new version of the nuget package with this added to the .nuspec file? It would help me a lot since currently my own package doesn't work because of this issue.

best regards Mads

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PicNet/XGBoost.Net/issues/24, or mute the thread https://github.com/notifications/unsubscribe-auth/AAITHVrm0mPI1sorAv3qcBAUlEwjRzk8ks5t0m76gaJpZM4UGkG8 .

mdabros commented 6 years ago

Hi Guido,

Thanks for responding to quickly! I have tested the new package and everything seems to work now. Thanks for your help!

best regards Mads

pranavmehta commented 5 years ago

@gatapia I still have have the exact same issue even though this has been marked as closed. Any tips to get it working would be helpful. Version 0.2.1 does not have this issue. Thanks.