search

PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
774 stars 243 forks source link

Cone angle #22

Closed jontromanab closed 8 years ago

jontromanab commented 8 years ago

The function of cone has an unused variable "angle" which should be varying the opening angle of the cone. Please check and update the function.

davetcoleman commented 8 years ago

Seems like you are merging the jade branch into the indigo branch, there are a lot of commits of mine in this PR. Can you target this PR for jade instead?

davetcoleman commented 8 years ago

@mcevoyandy you added publishCone, can you review it?

jontromanab commented 8 years ago

Do you want me to open a new PR with the jade branch?

davetcoleman commented 8 years ago

Yes please