search

Pidgeot / python-lnp

Cross-platform re-implementation of the Lazy Newb Pack launcher.
ISC License
64 stars 10 forks source link

Importing crashing on Linux #145

Closed Pidgeot closed 4 years ago

Pidgeot commented 4 years ago

Here is the relevant portion of my PyLNP.json:

  "to_import": [
    ["text_prepend", "<df>/gamelog.txt"],
    ["text_prepend", "<df>/ss_fix.log"],
    ["text_prepend", "<df>/dfhack.history"],
    ["copy_add", "<df>/data/save"],
    ["copy_add", "<df>/soundsense", "LNP/utilities/soundsense/packs"],
    ["copy_add", "LNP/utilities/soundsense/packs"]
  ],

I've made sure these folder paths exist in the pack I'm importing from, and double-checked capitalization in both the old pack and the to_import

When I go to import from an older version, I get the following error message output in the shell:

Traceback (most recent call last):
  File "<string>", line 12, in <module>
  File "python-lnp/core/lnp.py", line 125, in __init__
  File "python-lnp/tkgui/tkgui.py", line 716, in on_query_migration
  File "python-lnp/tkgui/tkgui.py", line 723, in migrate_settings
  File "python-lnp/core/importer.py", line 122, in do_imports
  File "genericpath.py", line 72, in commonprefix
ValueError: max() arg is an empty sequence
launch returned -1

When I get this error, PyLNP completely crashes out. I've tried to narrow down which line of the to_import section is causing this, but it seems to happen on both text_prepend and copy_add tags.

[Issue created by carter_scottm: 2016-08-31]

[Comment created by carter_scottm: 2016-08-31] Using the update code from the pull request, I was able to get everything to import (including the soundsense packs), but only when the packs are hosted inside the df_linux folder. (rather than LNP/utilities/soundsense/packs). I had to make my build script change the path in the configuration.xml for soundsense, but that was a trivial change.

[Comment created by jecowa: 2016-08-31] This issue is also effecting Mac (#120) and Windows (forum post report) users.

McArcady has been working on a fix – pull request #68 & pull request #69.

Have you already tried configuring your PyLNP.json to import the SoundSense sound pack? - https://bitbucket.org/Pidgeot/python-lnp#rst-header-to-import

[Comment created by carter_scottm: 2016-08-31] Just saw pull request #69, and can confirm that this fixes the issue. Still unable to import from LNP/utilities/soundsense though, which would be nice to do considering the download size of the sound clips.

[Comment created by carter_scottm: 2016-08-31] You're right. Sorry about that, I didn't see that there was already an issue open for this.

Duplicate of #120.