search

PieKing1215 / DripSounds-Fabric

Minecraft Fabric mod that adds sounds for drip particles landing
GNU Lesser General Public License v3.0
13 stars 4 forks source link

NOISSUE Consider not including ClothConfig. #3

Closed K0-RR closed 2 years ago

K0-RR commented 3 years ago

The file size would go down from 941 KiB >> 94.3 KiB. Many mods require ClothConfig and many of them bundle it so it gets included 50 times in any basic modpack. Even the modpack size gets like 30 MB bigger.

PieKing1215 commented 3 years ago

Thanks for letting me know! I just added a "no-bundled-cloth" jar as an additional file on the latest release on github, curseforge, and modrinth. (I'll probably stop making bundled versions in the future) I'm not sure how the curseforge desktop app handles "additional files" when making modpacks so let me know if that doesn't work!

itsdinkd commented 3 years ago

The config file is empty that generates.. is this normal? (for the regular mod with config API included)

PieKing1215 commented 3 years ago

It might not populate the file until you edit and save the config once in-game? I'm not exactly sure how that works.

itsdinkd commented 3 years ago

there is nothing to edit in modmenu, it doesn't give an option to edit anything. and then the file in config folder is blank

On Mon, Sep 20, 2021, 10:56 PM David M. @.***> wrote:

It might not populate the file until you edit and save the config once in-game? I'm not exactly sure how that works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PieKing1215/DripSounds-Fabric/issues/3#issuecomment-923652160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIL5CKDWXPY2EY6GGFPIEODUDAM75ANCNFSM5ASS7STQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

PieKing1215 commented 2 years ago

Starting in v0.3.0 cloth config is no longer bundled at all. I've also been doing this in my other mods as they get updated.

@red2blue If you're still having that problem you can make a new issue as it's not really related to this one.