search

PimvanderLoos / BigDoors

GNU General Public License v3.0
9 stars 4 forks source link

folia #13

Closed ewof closed 1 year ago

ewof commented 1 year ago

it uses UniversialScheduler it's pretty hacky (my pr not the UniversialScheduler library) and i have only tested on 1.20.1 u can feel free to ignore vertical doors and sliding doors dont animate idk y, drawbridges and normal doors work just fine

Anon8281 commented 1 year ago

Can you try #12? Have checked it on Folia 1.19.4, but I have not used this plugin before, so there may be some problems that I missed

ewof commented 1 year ago

trying #12 it works on folia 1.20.1 the sliding doors and portcullises still snap into place instead of sliding like they do in my fork but idk how to fix, normal doors and drawbridges work fine like they do here

ewof commented 1 year ago

i'll close this one soon, yours is probably better for a merge because of a lower diff count one thing though in your pr can you change setupEnv.sh to have these lines?

VERSIONS=(1.11.2 1.12.2 1.13 1.13.1 1.13.2 1.14.4 1.15.2 1.16.1 1.16.2 1.16.3 1.16.5 1.17.1 1.18.1 1.19 1.19.1 1.19.2 1.19.3 1.19.4 3798)
JAVA_VERSIONS=("$J_8" "$J_8" "$J_8" "$J_8" "$J_8" "$J_8" "$J_8" "$J_8" "$J_8" "$J_8" "$J_8" "$J_17" "$J_17" "$J_17" "$J_17" "$J_17" "$J_17" "$J_17" "$J_17")

when you run BuildTools for 1.20 it generates 1.20.1 for reason and the current script has duplicate versions and no 1.19 versions

Anon8281 commented 1 year ago

@ewof How can I contact you? What about twitter? https://twitter.com/SevastjAnon