PiotrMachowski / lovelace-xiaomi-vacuum-map-card

This card provides a user-friendly way to fully control map-based vacuums in Home Assistant. Supported brands include Xiaomi (Roborock/Viomi/Dreame/Roidmi/Valetudo/Valetudo RE), Neato, Wyze, Roomba, Ecovacs (and probably more).
MIT License
1.47k stars 252 forks source link

Support image entity as camera source #639

Open edenhaus opened 1 year ago

edenhaus commented 1 year ago

Description

Please also support the image entity as camera source. From the docs:

The image entity is a simplified version of the camera entity, and supports serving a static image or an image URL that can be fetched.

The image entity has also the attribute entity_picture, which (if I'm not wrong) is the only attribute required from the camera entity. https://github.com/PiotrMachowski/lovelace-xiaomi-vacuum-map-card/blob/228348622c196c4e6676e848f58f76e2e71f3d81/src/xiaomi-vacuum-map-card.ts#L600-L600

A quick test was working, if you add the image entity through yaml as shown below: grafik

Solution

Please edit the editor to also allow image entities. Maybe only the following line must be extended, but I'm not familiar with this components code

https://github.com/PiotrMachowski/lovelace-xiaomi-vacuum-map-card/blob/228348622c196c4e6676e848f58f76e2e71f3d81/src/editor.ts#L114-L114

Alternatives

No response

Context

With the next release of Deebot 4 Home Assistant(released on 02.08.23) the camera entity is replaced by the image entity as in fact the vacuum map is only a image in the end.

PiotrMachowski commented 1 year ago

Thank you for your investigation, I will definitely add it

Tasshack commented 1 year ago

I am also planning to change the camera entities of the dreame_vacuum to image entities.

PiotrMachowski commented 1 year ago

Well, I'm also planning to adjust Map Extractor 😉

regularguy01 commented 7 months ago

+1