search

Pirate-Weather / pirate-weather-ha

Replacement for the default Dark Sky Home Assistant integration using Pirate Weather
https://pirateweather.net/
Apache License 2.0
369 stars 26 forks source link

Updates based on blueprint #248

Closed cloneofghosts closed 5 months ago

cloneofghosts commented 5 months ago

The other day I noticed that the blueprint this integration is based on has been updated so I updated this repository with the updated code. The updates mainly focused on the devcontainer but there were updates to the linting rules which I also fixed any errors relating to that. I tested on a devcontainer and everything is working as expected.

I was going to use the lint rules from the blueprint but they had everything enabled which seemed overkill so I'm using the rules that HA is using.

Fixes #246

cloneofghosts commented 5 months ago

I see that CodeQL caught the issue I mentioned in #246 in this PR (I changed the code slightly to fix lint error). Do we just dismiss it or change the line to not include their location?

alexander0042 commented 5 months ago

Code checks are getting so good, that's pretty impressive! Also, thank you for updating to correspond to the blueprint, since it really helps to avoid major issues when changes are required.

Re: the lines, I think we just drop them from the logs. It's not particularly relevant for most debugging operations, and likely would be more useful to have the name anyway. I'll make that change to this branch and we can merge it as one

cloneofghosts commented 5 months ago

Everything is all merged in. There was a weird error where the lint changes didn't get committed but it seems to have sorted itself out.

Most of the updates from the blueprint will likely be to the devcontainer and will probably not change much of the integration itself.