Closed cloneofghosts closed 1 month ago
Great clean-up catches here! To address in detail:
- This is intentional. ERA5 doesn't have historic instant intensity, only accumulations, so everything is per hour. For currently, the hourly average is used since current accumulation doesn't make sense, but I think it's clearer to label it as an accumulation in the other blocks.
Isn't precipIntensity
just precipAccumulation
multiplied by 10 to convert from cm to mm? You could probably just do the same here no?
- I really like trying to show snow vs rain, so since this data point is in the NCAR archive and the PW one, I figured it was worth including!
The only reason I mentioned it is that Dark Sky never had a snowAccumulation
field in their data points.
Re intensity, the answer is that it depends. For NBM, which is usually the source accumulation is 10x intensity. However, for GFS and HRRR rate and intensity are two separate products (PRATE
and APCP
), so can diverge. That's the rational for specifying intensity vs accumulation in time machine, but as I think about it, I sort of agree that it's easier for everyone if they're both in there
Ok, added intensity back in, should propagate out in the next hour or so!
Everything is looking good for the most part but I see two minor issues:
PW archive data has visibility
in the daily block when it should be behind the query string and the summaries for the hourly blocks and daily block are still there.
hourly": {
"summary": "Clear",
"icon": "clear-day",
"data": [
{
Was this missed or will it be there for the PW Archive data? The ERA5 data doesn't have them showing so should ideally be consistent.
You are amazing with these sorts of catches! It was just missed, fixing it now
Just checked and things are looking good now so can close.
Describe the issue
I had posted this in #130 but I figure I'd post it here. Most of this is an issue when accessing the ERA5 dataset and not the PW archive
windGust
should be right belowwindSpeed
precipIntensity
only appears on the currently block and nowhere elseprecipAccumulation
is rounded to two decimal places instead of foursnowAccumulation
data point which shouldn't be thereAcknowledgements