search

Pirate-Weather / pirateweather

Code and documentation for the Pirate Weather API
Apache License 2.0
670 stars 29 forks source link

Precipitation Types #43

Open cloneofghosts opened 1 year ago

cloneofghosts commented 1 year ago

This issue is a continuation of the discussion from this issue https://github.com/alexander0042/pirate-weather-ha/issues/78 and since the discussion about adding other precipitation types.

I know that DarkSky is pretty limited when it comes to precipitation types (as well as icons) and I am aware that you want to keep things compatible with DarkSky and using flags/API options instead of breaking things. I know that WeatherKit has added in more icons/precipitation types to their API so maybe it's worth breaking things in this case?

Maybe the following could be added as precipTypes:

I thought about adding in thunderstorm but since it isn't a form of precipitation I decided to exclude it. I was thinking about thunderstorms today and it would be a nice addition to the API. I know there are ways to forecast using Lifted Index/CAPE/precipRate/wind speed/etc. and using the Blitzortung (#6) to show in the currently section.

I would show the icon only if precipType is rain and it would always come after the precipType so if we use today as an example it would show Freezing Rain and Thunderstorms.

EDIT: I might be misunderstanding the Categorical Ice/Rain/Snow/Sleet that HRRR offers. During precipitation only one of those four values will be 1 and the rest 0? If that's the case then maybe we can not bother adding in mixed as a precipType

cloneofghosts commented 1 year ago

This issue was probably missed so will bump for visibility. Probably more of a long-term issue here so adding the keep label would be useful.