Pitmairen / selection-search

Search extension for the chrome web browser
GNU General Public License v3.0
184 stars 26 forks source link

Latest version seems to be broken in Edge, causing high CPU usage and page loading failures #161

Open bsiegel opened 2 months ago

bsiegel commented 2 months ago

I'm using the Chrome version of this addon in Microsoft Edge. After updating to 0.9.2, in my browser pages appear to never stop loading, CPU usage is extremely high, and in the console I see a constant spam of this error message:

GET chrome-extension://invalid/ net::ERR_FAILED

In the network tab, it showed the source of these requests as coming from this extension in popup.js Line 166:

 this.src = chrome.runtime.getURL('img/default_favicon.png');

I confirmed that disabling this extension fixes the issues.

Pitmairen commented 2 months ago

In the network tab, before the error messages, do you see any lines starting with data:image/... or something similar? And if you click these lines and open the "preview" tab, do you see the icons?

The line with img/default_favicon.png is a fallback icon in case the regular icons fail to load. But it looks like there may be something wrong with getting the icons, so the fallback probably also fails, and it ends up in a loop.

If you click the extension icon => Manage Extension => Enable developer mode => click the Inspect views service worker line.

Do you see any error messages in the console or network tab in the inspect window?

Pitmairen commented 1 month ago

Should be fixed in version 0.9.3, which should be available shortly.