search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Dark color palette #201

Closed Valou447 closed 4 years ago

Valou447 commented 4 years ago
Valou447 commented 4 years ago

Yet we are facing this issue which has no workaround or fix yet..

ramack commented 4 years ago

Yet we are facing this issue which has no workaround or fix yet..

I did not search, for anything, but if it is a bug, that is there in android <=23, then I'd propose to hide the setting for all those versions and just set it to auto. - Anyhow Auto might be a good default instead of light.

Valou447 commented 4 years ago

Yet we are facing this issue which has no workaround or fix yet..

I did not search, for anything, but if it is a bug, that is there in android <=23, then I'd propose to hide the setting for all those versions and just set it to auto. - Anyhow Auto might be a good default instead of light.

Auto means "FOLLOW_SYSTEM". As night mode has only been introduced in Android 9 Pie, everybody with API < 23 would stay with the light mode.

Another idea is to advise people with API < 23 that switching to night mode requires the app to restart..

ramack commented 4 years ago

Are there already the time based switching options? If the restart is possible to handle in a easy and robust way that is for sure also a good option.

ramack commented 4 years ago

Are there already the time based switching options? If the restart is possible to handle in a easy and robust way that is for sure also a good option but we should tell the user that this setting.will take effect.only after a restart. (I guess automatic restart is quite some effort)

Valou447 commented 4 years ago

Automatic restart may not be a big deal, but I don't think there is some time-related option..

ramack commented 4 years ago

From here I understand, that MODE_NIGHT_AUTO_BATTERY would be the choice for "auto" in API 21-27 and with 28 or later use FOLLOW_SYSTEM.

ramack commented 4 years ago

maybe you can add the comment about the preference repository and merge it