search

Piwigo / Piwigo-Android

Piwigo Native Android App
GNU General Public License v3.0
140 stars 43 forks source link

Album item #210

Closed Walikdik closed 4 years ago

Walikdik commented 4 years ago

Here is my new Pull request. Do not really know how to remove other commits.

ramack commented 4 years ago

oh, I missed another point... Travis detects a compile issue:

> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
   > Android resource linking failed
     /home/travis/build/Piwigo/Piwigo-Android/app/src/main/res/layout/item_album.xml:87: AAPT: error: resource color/piwigo_dark_text_color (aka org.piwigo.android.debug:color/piwigo_dark_text_color) not found.

Maybe you can fix it?

Valou447 commented 4 years ago

Please do not add back the "piwigo_dark_text_color" value, as it has been removed for the light/dark theme purpose.

By the way, the dark theme is not supported at all, which is a big issue yet.

Could you try to take a look on this ?

Take a look at res/styles.xml (night) and res/colors.xml (night), it may help you :)

ramack commented 4 years ago

Thanks for the update. I could give it a try now and I really like it. Just two more concerns about the UI:

ramack commented 4 years ago

Thanks for the update. I could give it a try now and I really like it. Just two more concerns about the UI:

* The image box is filled orange before the photo is loaded. This is quite strong, can you make it only showing an orange border instead of filling the box?

* Dark mode is not supported yet. Here I think we should replace the white background by a dark grey or even complete black and also here use just an outline to show highlight the card/ticket

@Walikdik can you improve those points, such that we can get this merged soon?

ramack commented 4 years ago

@Walikdik what about the Dark mode support? Can you add it such that we can merge your work?